Messages in this thread | | | Subject | Re: [PATCH v2 15/18] firmware: qcom_scm-32: Add device argument to atomic calls | From | Stephen Boyd <> | Date | Tue, 19 Nov 2019 14:13:52 -0800 |
| |
Quoting Elliot Berman (2019-11-12 13:22:51) > Add this unused parameter to reduce merge friction between SMCCC and > legacy based conventions.
in an upcoming patch.
> > Signed-off-by: Elliot Berman <eberman@codeaurora.org> > --- > drivers/firmware/qcom_scm-32.c | 17 +++++++++-------- > drivers/firmware/qcom_scm-64.c | 5 +++-- > drivers/firmware/qcom_scm.c | 5 +++-- > drivers/firmware/qcom_scm.h | 5 +++-- > 4 files changed, 18 insertions(+), 14 deletions(-) > > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c > index eca18e1..c1c0831 100644 > --- a/drivers/firmware/qcom_scm-32.c > +++ b/drivers/firmware/qcom_scm-32.c > @@ -269,7 +269,7 @@ static int qcom_scm_call(struct device *dev, struct qcom_scm_desc *desc) > * This shall only be used with commands that are guaranteed to be > * uninterruptable, atomic and SMP safe. > */ > -static int qcom_scm_call_atomic(struct qcom_scm_desc *desc) > +static int qcom_scm_call_atomic(struct device *dev, struct qcom_scm_desc *desc)
If the argument is unused, how about call it 'struct device *unused' so we can ignore it?
> { > int context_id; > struct arm_smccc_args smc = {0};
| |