Messages in this thread | | | Subject | Re: [PATCH][next] net: phy: dp83869: fix return of uninitialized variable ret | From | Dan Murphy <> | Date | Tue, 19 Nov 2019 11:27:45 -0600 |
| |
Andrew
On 11/18/19 5:29 PM, Andrew Lunn wrote: > On Mon, Nov 18, 2019 at 11:48:35AM +0000, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> In the case where the call to phy_interface_is_rgmii returns zero >> the variable ret is left uninitialized and this is returned at >> the end of the function dp83869_configure_rgmii. Fix this by >> returning 0 instead of the uninitialized value in ret. >> >> Addresses-Coverity: ("Uninitialized scalar variable") >> Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Dan: phy_modify_mmd() could fail. You check the return value for > phy_read and phy_write, so it would be consistent to also check
Thanks for the heads up on this.
I need to check the set/clear_mmd bits too.
Dan
> Andrew
| |