Messages in this thread | | | From | Shakeel Butt <> | Date | Tue, 19 Nov 2019 08:49:34 -0800 | Subject | Re: [PATCH v4 3/9] mm/lru: replace pgdat lru_lock with lruvec lock |
| |
On Tue, Nov 19, 2019 at 4:24 AM Alex Shi <alex.shi@linux.alibaba.com> wrote: > > This patchset move lru_lock into lruvec, give a lru_lock for each of > lruvec, thus bring a lru_lock for each of memcg per node. > > This is the main patch to replace per node lru_lock with per memcg > lruvec lock. > > We introduce function lock_page_lruvec, it's same as vanilla pgdat lock > when memory cgroup unset, w/o memcg, the function will keep repin the > lruvec's lock to guard from page->mem_cgroup changes in page > migrations between memcgs. (Thanks Hugh Dickins and Konstantin > Khlebnikov reminder on this. Than the core logical is same as their > previous patchs) > > According to Daniel Jordan's suggestion, I run 64 'dd' with on 32 > containers on my 2s* 8 core * HT box with the modefied case: > https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice > > With this and later patches, the dd performance is 144MB/s, the vanilla > kernel performance is 123MB/s. 17% performance increased. > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Vladimir Davydov <vdavydov.dev@gmail.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Roman Gushchin <guro@fb.com> > Cc: Shakeel Butt <shakeelb@google.com> > Cc: Chris Down <chris@chrisdown.name> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Qian Cai <cai@lca.pw> > Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Cc: "Jérôme Glisse" <jglisse@redhat.com> > Cc: Andrea Arcangeli <aarcange@redhat.com> > Cc: Yang Shi <yang.shi@linux.alibaba.com> > Cc: David Rientjes <rientjes@google.com> > Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> > Cc: swkhack <swkhack@gmail.com> > Cc: "Potyra, Stefan" <Stefan.Potyra@elektrobit.com> > Cc: Mike Rapoport <rppt@linux.vnet.ibm.com> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Colin Ian King <colin.king@canonical.com> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Nikolay Borisov <nborisov@suse.com> > Cc: Ira Weiny <ira.weiny@intel.com> > Cc: Kirill Tkhai <ktkhai@virtuozzo.com> > Cc: Yafang Shao <laoar.shao@gmail.com> > Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> > Cc: Hugh Dickins <hughd@google.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: cgroups@vger.kernel.org
This patch (and series) still have unsafe accesses to lruvec.
Alex, I was hoping that you would drop this series in favor of Hugh's patches. Anyways I will post Hugh patches for review to be considered for 5.6. I will run a couple of performance experiments.
Shakeel
| |