lkml.org 
[lkml]   [2019]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH v8 2/6] ASoC: amd: Refactoring of DAI from DMA driver
From
Date


> +static int acp3x_dai_probe(struct platform_device *pdev)
> +{
> + struct resource *res;
> + struct i2s_dev_data *adata;
> + int status;
> +
> + adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data),
> + GFP_KERNEL);
> + if (!adata)
> + return -ENOMEM;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
> + return -ENOMEM;
> + }
> +
> + adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
> + resource_size(res));
> + if (IS_ERR(adata->acp3x_base))
> + return PTR_ERR(adata->acp3x_base);
> +
> + adata->i2s_irq = res->start;
> + dev_set_drvdata(&pdev->dev, adata);
> + status = devm_snd_soc_register_component(&pdev->dev,
> + &acp3x_dai_component, &acp3x_i2s_dai, 1);
> + if (status) {
> + dev_err(&pdev->dev, "Fail to register acp i2s dai\n");
> + return -ENODEV;
> + }
> + pm_runtime_set_autosuspend_delay(&pdev->dev, 5000);
> + pm_runtime_use_autosuspend(&pdev->dev);
> + pm_runtime_enable(&pdev->dev);

question: here you want to use pm_runtime for this platform device...

> + return 0;
> +}
> +
> +static int acp3x_dai_remove(struct platform_device *pdev)
> +{
> + pm_runtime_disable(&pdev->dev);
> + return 0;
> +}
> +static struct platform_driver acp3x_dai_driver = {
> + .probe = acp3x_dai_probe,
> + .remove = acp3x_dai_remove,
> + .driver = {
> + .name = "acp3x_i2s_playcap",

... but here there is no .pm structure and I don't see any
suspend/resume routines for this driver...

> + },
> +};

> @@ -774,13 +586,14 @@ static struct platform_driver acp3x_dma_driver = {
> .probe = acp3x_audio_probe,
> .remove = acp3x_audio_remove,
> .driver = {
> - .name = "acp3x_rv_i2s",
> + .name = "acp3x_rv_i2s_dma",
> .pm = &acp3x_pm_ops,
> },

... but for this other platform_driver you do have a .pm structure and
suspend-resume implementations.

Wondering if this is a miss or a feature?

\
 
 \ /
  Last update: 2019-11-19 15:27    [W:0.078 / U:1.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site