Messages in this thread | | | Date | Mon, 18 Nov 2019 20:22:57 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH v2] {tty: serial, nand: onenand}: samsung: rename to fix build warning |
| |
Hi all,
Richard Weinberger <richard@nod.at> wrote on Mon, 18 Nov 2019 13:47:50 +0100 (CET):
> ----- Ursprüngliche Mail ----- > >> I was not sure if this should have been two different patch, but since > >> this will be fixing the same problem so it seems its better to have them > >> in a single patch. > >> > >> drivers/mtd/nand/onenand/Makefile | 2 +- > >> drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} | 0 > >> drivers/tty/serial/Makefile | 2 +- > >> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0 > >> 4 files changed, 2 insertions(+), 2 deletions(-) > >> rename drivers/mtd/nand/onenand/{samsung.c => samsung_mtd.c} (100%) > >> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%) > > > > I can take this in the tty tree if the mtd maintainer gives an ack for > > it... > > Acked-by: Richard Weinberger <richard@nod.at>
If it is not too late, I am not a big fan of the new naming which is rather not descriptive. Files in the onenand subdirectory are: * onenand_<something>.c for the base files * <vendor>.c for the vendors files (currently: omap2.c and samsung.c).
What about doing the MTD changes in a single patch and renaming both vendor drivers (for the same reason): onenand_omap2.c and onenand_samsung.c? I know it makes git blaming more difficult though.
Thanks, Miquèl
| |