Messages in this thread | | | Date | Mon, 18 Nov 2019 16:02:40 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/resctrl: Fix potential lockdep warning |
| |
On Sun, Nov 17, 2019 at 12:13:20AM +0800, Xiaochen Shen wrote: > Actually this fix covers all the cases of an audit of the calling paths > of rdt_last_cmd_{clear,puts,printf}(), to make sure we only have the > lockdep_assert_held() in places where we are sure that it must be held.
That's kinda what I suggested, isn't it?
All I meant was, not to have a
rdtgroup_kn_lock_live()
call in the code as this function does *not* unconditionally grab the rdtgroup_mutex. And then call a function which unconditionally checks whether the mutex is held.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |