lkml.org 
[lkml]   [2019]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] perf session: fix decompression of PERF_RECORD_COMPRESSED records
From
Date
On 18.11.2019 15:22, Jiri Olsa wrote:
> On Mon, Nov 18, 2019 at 02:30:04PM +0300, Alexey Budankov wrote:
<SNIP>
>>
>> @@ -1971,20 +1971,32 @@ fetch_mmaped_event(struct perf_session *session,
>> return NULL;
>>
>> event = (union perf_event *)(buf + head);
>> + if (needs_swap)
>> + perf_event_header__bswap(&event->header);
>>
>> - if (session->header.needs_swap)
>> + if (head + event->header.size <= mmap_size)
>> + return event;
>> +
>> + /* We're not fetching the event so swap back again */
>> + if (needs_swap)
>> perf_event_header__bswap(&event->header);
>>
>> - if (head + event->header.size > mmap_size) {
>> - /* We're not fetching the event so swap back again */
>> - if (session->header.needs_swap)
>> - perf_event_header__bswap(&event->header);
>> - pr_debug("%s: head=%#" PRIx64 " event->header_size=%#x, mmap_size=%#zx: fuzzed perf.data?\n",
>> - __func__, head, event->header.size, mmap_size);
>> - return ERR_PTR(-EINVAL);
>> - }
>> + pr_debug("%s: head=%#" PRIx64 " event->header_size=%#x, mmap_size=%#zx\n",
>> + __func__, head, event->header.size, mmap_size);
>
> you're missign the 'fuzzed perf.data?' in here
>
> I think we should keep it just change to: 'fuzzed or compressed perf.data?'

Fixed in v3.

>
> thanks,
> jirka

~Alexey

\
 
 \ /
  Last update: 2019-11-18 15:21    [W:0.054 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site