lkml.org 
[lkml]   [2019]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 42/48] soc: fsl: qe: drop pointless check in qe_sdma_init()
    Date
    The sdma member of struct qe_immap is not at offset zero, so even if
    qe_immr wasn't initialized yet (i.e. NULL), &qe_immr->sdma would not
    be NULL.

    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    drivers/soc/fsl/qe/qe.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
    index 5bf279c679ef..96c2057d8d8e 100644
    --- a/drivers/soc/fsl/qe/qe.c
    +++ b/drivers/soc/fsl/qe/qe.c
    @@ -367,9 +367,6 @@ static int qe_sdma_init(void)
    struct sdma __iomem *sdma = &qe_immr->sdma;
    static s32 sdma_buf_offset = -ENOMEM;

    - if (!sdma)
    - return -ENODEV;
    -
    /* allocate 2 internal temporary buffers (512 bytes size each) for
    * the SDMA */
    if (sdma_buf_offset < 0) {
    --
    2.23.0
    \
     
     \ /
      Last update: 2019-11-18 12:25    [W:4.261 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site