Messages in this thread | | | Subject | Re: [PATCH v3 3/8] ARM: dts: Prepare Realtek RTD1195 and MeLE X1000 | Date | Mon, 18 Nov 2019 09:14:17 +0000 | From | Marc Zyngier <> |
| |
On 2019-11-18 01:24, Andreas Färber wrote: > Am 17.11.19 um 17:22 schrieb Marc Zyngier: >> On Sun, 17 Nov 2019 15:40:59 +0000, >> Andreas Färber <afaerber@suse.de> wrote: >>> Am 17.11.19 um 11:47 schrieb Marc Zyngier: >>>> On Sun, 17 Nov 2019 08:21:04 +0100 >>>> Andreas Färber <afaerber@suse.de> wrote: >>>>> + timer { >>>>> + compatible = "arm,armv7-timer"; >>>>> + interrupts = <GIC_PPI 13 >>>>> + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, >>>>> + <GIC_PPI 14 >>>>> + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, >>>>> + <GIC_PPI 11 >>>>> + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, >>>>> + <GIC_PPI 10 >>>>> + (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; >>>>> + clock-frequency = <27000000>; >>>> >>>> This is 2019, and yet it feels like 2011. This should be setup in >>>> the >>>> bootloader, not in DT... >>> >>> What exactly - the whole node, the GIC CPU mask, the >>> clock-frequency? >> >> The clock frequency. Having to rely on such hacks 8 years down the >> line makes me feel like we've achieved nothing... >> </depressed> > > Unfortunately I can confirm that without clock-frequency property I > get:
[trace showing how bad firmware can be]
I don't dispute that you need this for your broken bootloader.
But instead of adding hacks upon hacks to the kernel to support subpar implementations, maybe you should consider putting efforts in a u-boot port that doesn't suck.
M. -- Jazz is not dead. It just smells funny...
| |