lkml.org 
[lkml]   [2019]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] gpu: ipu-v3: prg: add missed operations in remove
    Date
    This driver forgets to call pm_runtime_disable and clk_disable_unprepare
    in remove.
    Add the calls to fix it.

    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    ---
    Changes in v2:
    - Add the missed pm_runtime_disable.

    drivers/gpu/ipu-v3/ipu-prg.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
    index 196797c1b4b3..897da605da55 100644
    --- a/drivers/gpu/ipu-v3/ipu-prg.c
    +++ b/drivers/gpu/ipu-v3/ipu-prg.c
    @@ -430,6 +430,9 @@ static int ipu_prg_remove(struct platform_device *pdev)
    list_del(&prg->list);
    mutex_unlock(&ipu_prg_list_mutex);

    + pm_runtime_disable(&pdev->dev);
    + clk_disable_unprepare(prg->clk_axi);
    + clk_disable_unprepare(prg->clk_ipg);
    return 0;
    }

    --
    2.24.0
    \
     
     \ /
      Last update: 2019-11-18 09:09    [W:3.729 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site