Messages in this thread | | | Date | Fri, 15 Nov 2019 11:52:24 -0600 | From | Josh Poimboeuf <> | Subject | Re: [RFC PATCH v4 0/7] Speed booting by sorting ORC unwind tables at build time |
| |
On Sat, Nov 16, 2019 at 12:45:32AM +0800, Shile Zhang wrote: > Hi, > > I refactored the code, followed by Peter's suggestions in v3, thank you! > Any suggestions and comments are welcome! > > Thanks! > > Changelog: > ========== > v3->v4: > - Code refactored for Peter's review findings and suggestions.
Hi Shile,
I haven't given it a proper review yet, but one minor suggestion. In general it's good practice to wait at least a few business days before posting a new version of a patch set. That way it gives people time to review, and it also helps to avoid flooding people's inboxes.
-- Josh
| |