lkml.org 
[lkml]   [2019]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 1/2] fork: extend clone3() to support setting a PID
From
Date
On 11/15/19 12:36 PM, Adrian Reber wrote:
[..]
> Signed-off-by: Adrian Reber <areber@redhat.com>
> Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>

Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>

[though, I have 2 minor nits below]

[..]
> + * @set_tid: Pointer to an array of type *pid_t. The size
> + * of the array is defined using @set_tid_size.
> + * This array is used select PIDs/TIDs for newly

/is used select/is used to select/s


[..]
> + size_t set_tid_size;
> + __aligned_u64 set_tid_size;

[..]
> + .set_tid_size = args.set_tid_size,

Is sizeof(size_t) == 32 on native 32-bit platforms?
Maybe `args.set_tid_size` should be checked?

Thanks,
Dmitry

\
 
 \ /
  Last update: 2019-11-15 17:54    [W:0.067 / U:13.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site