Messages in this thread | | | Date | Fri, 15 Nov 2019 14:34:45 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v1 2/2] perf report: Jump to symbol source view from total cycles view |
| |
On Wed, Nov 13, 2019 at 08:48:52AM +0800, Jin Yao wrote:
SNIP
> diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h > index e8b3122a30a7..5bf122042c01 100644 > --- a/tools/perf/util/hist.h > +++ b/tools/perf/util/hist.h > @@ -478,7 +478,8 @@ int res_sample_browse(struct res_sample *res_samples, int num_res, > void res_sample_init(void); > > int block_hists_tui_browse(struct block_hist *bh, struct evsel *evsel, > - float min_percent); > + float min_percent, struct perf_env *env, > + struct annotation_options *annotation_opts); > #else > static inline > int perf_evlist__tui_browse_hists(struct evlist *evlist __maybe_unused, > @@ -525,7 +526,9 @@ static inline void res_sample_init(void) {} > > int block_hists_tui_browse(struct block_hist *bh __maybe_unused, > struct evsel *evsel __maybe_unused, > - float min_percent __maybe_unused) > + float min_percent __maybe_unused, > + struct perf_env *env __maybe_unused, > + struct annotation_options *annotation_opts)
missing __maybe_unused, this breaks no-tui build 'make NO_SLANG=1'
jirka
| |