Messages in this thread | | | Date | Fri, 15 Nov 2019 11:34:34 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 06/16] x86/cpu: Clear VMX feature flag if VMX is not fully enabled |
| |
On Fri, Nov 15, 2019 at 11:05:24AM +0100, Paolo Bonzini wrote: > On 14/11/19 19:32, Sean Christopherson wrote: > >>> + pr_err_once("x86/cpu: VMX disabled, IA32_FEATURE_CONTROL MSR unsupported\n"); > > > > My thought for having the print was to alert the user that something is > > royally borked with their system. There's nothing the user can do to fix > > it per se, but it does indicate that either their hardware or the VMM > > hosting their virtual machine is broken. So maybe be more explicit about > > it being a likely hardware/VMM issue? > > Yes, good idea.
Yah, let's make sure it has some merit for users and doesn't make them only shrug and ignore it.
Btw, Sean, are you sending a new version of this ontop of latest tip/master or linux-next or so? I'd like to look at the rest of the bits in detail.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |