lkml.org 
[lkml]   [2019]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RDMA/iw_cgxb4: Fix an error handling path in 'c4iw_connect()'
    On Mon, Sep 23, 2019 at 09:07:46PM +0200, Christophe JAILLET wrote:
    > We should jump to fail3 in order to undo the 'xa_insert_irq()' call.
    >
    > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    > ---
    > Not sure which Fixes tag to use because of the many refactorings in this
    > area. So I've choosen to use none :).
    > The issue was already there in 4a740838bf44c. This commit has renamed
    > all labels because a new fail1 was introduced. I've not searched further.
    >
    > Naming of error labels should be improved. Having nowadays a fail5
    > between fail2 and fail3 (because fail5 was the last
    > error handling path added) is not that readable.
    > However, it goes beyong the purpose of this patch.
    >
    > Maybe, just using a fail2a, just as already done in 9f5a9632e412 (which
    > introduced fail5) would be enough.
    > ---
    > drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)

    The disaster of the error label aside, this does fix the bug, so
    applied to for-next

    Thanks,
    Jason

    \
     
     \ /
      Last update: 2019-11-15 22:01    [W:5.649 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site