lkml.org 
[lkml]   [2019]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove
From
From: Chuhong Yuan <hslester96@gmail.com>
Date: Thu, 14 Nov 2019 23:43:24 +0800

> The driver calls release_resource in remove to match request_mem_region
> in probe, which is incorrect.
> Fix it by using the right one, release_mem_region.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Applied, thanks.

It's a shame that you can't just pass in the thing you got back from
request_mem_region() to free it. And honestly the only thing that makes
calling release_region() wrong is that release_region() doesn't free up
the region object after unlinking it from the tree.

\
 
 \ /
  Last update: 2019-11-15 21:43    [W:0.055 / U:18.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site