lkml.org 
[lkml]   [2019]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 14/14] arm64: implement Shadow Call Stack
    On Fri, Nov 15, 2019 at 7:20 AM Mark Rutland <mark.rutland@arm.com> wrote:
    >
    > On Tue, Nov 05, 2019 at 03:56:08PM -0800, Sami Tolvanen wrote:
    > > This change implements shadow stack switching, initial SCS set-up,
    > > and interrupt shadow stacks for arm64.
    >
    > Each CPU also has an overflow stack, and two SDEI stacks, which should
    > presumably be given their own SCS. SDEI is effectively a software-NMI,
    > so it should almost certainly have the same treatement as IRQ.

    Makes sense. I'll take a look at adding shadow stacks for the SDEI handler.

    > Can we please fold this comment into the one above, and have:
    >
    > /*
    > * The callee-saved regs (x19-x29) should be preserved between
    > * irq_stack_entry and irq_stack_exit.
    > */
    > .macro irq_stack_exit
    > mov sp, x19
    > #ifdef CONFIG_SHADOW_CALL_STACK
    > mov x18, x20
    > #endif
    > .endm

    Sure, I'll change this in the next version.

    Sami

    \
     
     \ /
      Last update: 2019-11-15 21:20    [W:4.483 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site