lkml.org 
[lkml]   [2019]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 2/7] x86/intel_pmc_core: Clean up: Remove comma after the termination line
    Date
    It is common practice to place a comma after the last entry in an
    initialized array to avoid the need to add one in future patches that
    extend the array. But when the last element is a termination marker, the
    comma could be harmful. Any new entries must be added before the
    terminator (and the comma would prevent the compiler from issuing a
    warning about an entry after the terminator).

    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Cc: Kan Liang <kan.liang@intel.com>
    Cc: David E. Box <david.e.box@intel.com>
    Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
    Cc: Tony Luck <tony.luck@intel.com>
    Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Reviewed-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
    ---
    drivers/platform/x86/intel_pmc_core.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
    index 6b6edc30f835..3c07a0172764 100644
    --- a/drivers/platform/x86/intel_pmc_core.c
    +++ b/drivers/platform/x86/intel_pmc_core.c
    @@ -49,7 +49,7 @@ static const struct pmc_bit_map spt_pll_map[] = {
    {"GEN2 USB2PCIE2 PLL", SPT_PMC_BIT_MPHY_CMN_LANE1},
    {"DMIPCIE3 PLL", SPT_PMC_BIT_MPHY_CMN_LANE2},
    {"SATA PLL", SPT_PMC_BIT_MPHY_CMN_LANE3},
    - {},
    + {}
    };

    static const struct pmc_bit_map spt_mphy_map[] = {
    @@ -69,7 +69,7 @@ static const struct pmc_bit_map spt_mphy_map[] = {
    {"MPHY CORE LANE 13", SPT_PMC_BIT_MPHY_LANE13},
    {"MPHY CORE LANE 14", SPT_PMC_BIT_MPHY_LANE14},
    {"MPHY CORE LANE 15", SPT_PMC_BIT_MPHY_LANE15},
    - {},
    + {}
    };

    static const struct pmc_bit_map spt_pfear_map[] = {
    @@ -113,7 +113,7 @@ static const struct pmc_bit_map spt_pfear_map[] = {
    {"CSME_SMS1", SPT_PMC_BIT_CSME_SMS1},
    {"CSME_RTC", SPT_PMC_BIT_CSME_RTC},
    {"CSME_PSF", SPT_PMC_BIT_CSME_PSF},
    - {},
    + {}
    };

    static const struct pmc_bit_map spt_ltr_show_map[] = {
    @@ -299,7 +299,7 @@ static const struct pmc_bit_map *cnp_slps0_dbg_maps[] = {
    cnp_slps0_dbg0_map,
    cnp_slps0_dbg1_map,
    cnp_slps0_dbg2_map,
    - NULL,
    + NULL
    };

    static const struct pmc_bit_map cnp_ltr_show_map[] = {
    @@ -820,7 +820,7 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_ids);

    static const struct pci_device_id pmc_pci_ids[] = {
    { PCI_VDEVICE(INTEL, SPT_PMC_PCI_DEVICE_ID), 0},
    - { 0, },
    + { 0, }
    };

    /*
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-11-14 18:02    [W:4.873 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site