Messages in this thread | | | Date | Thu, 14 Nov 2019 11:33:50 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe' |
| |
On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote: > On Thu 2019-11-14 11:04:16, Uwe Kleine-König wrote: > > This extension was introduced in commit 57f5677e535b ("printf: add > > support for printing symbolic error names"). > > Great catch!
It wasn't hard to catch. checkpatch pelted me with bogus warnings when I started to make use of %pe :-)
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > scripts/checkpatch.pl | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 6fcc66afb088..31cd9b767c1e 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -6022,7 +6022,7 @@ sub process { > > while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) { > > $specifier = $1; > > $extension = $2; > > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) { > > + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) { > > I am going to push it into printk.git. I will just change the ordering > "eE" -> "Ee". So that it follows the existing convention.
Fine for me. Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
| |