Messages in this thread | | | Date | Thu, 14 Nov 2019 11:33:10 +0100 | From | walter harms <> | Subject | Re: [PATCH] staging: rtl8192u: fix indentation issue |
| |
Am 14.11.2019 10:54, schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 ++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > index e064f43fd8b6..bc98cdaf61ec 100644 > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c > @@ -169,19 +169,20 @@ static void cmdpkt_beacontimerinterrupt_819xusb(struct net_device *dev) > { > struct r8192_priv *priv = ieee80211_priv(dev); > u16 tx_rate; > - /* 87B have to S/W beacon for DTM encryption_cmn. */ > - if (priv->ieee80211->current_network.mode == IEEE_A || > - priv->ieee80211->current_network.mode == IEEE_N_5G || > - (priv->ieee80211->current_network.mode == IEEE_N_24G && > - (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > - tx_rate = 60; > - DMESG("send beacon frame tx rate is 6Mbpm\n"); > - } else { > - tx_rate = 10; > - DMESG("send beacon frame tx rate is 1Mbpm\n"); > - } > > - rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ > + /* 87B have to S/W beacon for DTM encryption_cmn. */ > + if (priv->ieee80211->current_network.mode == IEEE_A || > + priv->ieee80211->current_network.mode == IEEE_N_5G || > + (priv->ieee80211->current_network.mode == IEEE_N_24G && > + (!priv->ieee80211->pHTInfo->bCurSuppCCK))) { > + tx_rate = 60; > + DMESG("send beacon frame tx rate is 6Mbpm\n"); > + } else { > + tx_rate = 10; > + DMESG("send beacon frame tx rate is 1Mbpm\n"); > + } > + > + rtl819xusb_beacon_tx(dev, tx_rate); /* HW Beacon */ > } > > /*-----------------------------------------------------------------------------
this is hard to read in the first place. Maybe using switch() here is better to read (untested example below).
switch(priv->ieee80211->current_network.mode) {
case IEEE_A: case IEEE_N_5G: tx_rate = 60; break; IEEE_N_24G: if ( !priv->ieee80211->pHTInfo->bCurSuppCCK ) tx_rate = 60; // fall truh
default: tx_rate = 10;
}
if (txrate == 60 ) DMESG("send beacon frame tx rate is 6Mbpm\n"); else if (txrate == 10 ) DMESG("send beacon frame tx rate is 1Mbpm\n");
JM2C
re, wh
| |