lkml.org 
[lkml]   [2019]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
Hi Peter,

> if (!is_polling(sdd)) {
> /* Acquire DMA channels */
> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
> - "rx");
> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");

I have a little concern here. We have two funcions
'dma_request_chan' and 'dma_request_channel' don't we end up
making some confusion here?

Wouldn't it make more sense renaming 'dma_request_chan' to
'dma_request_slave_channel_reason'?

Thanks,
Andi

\
 
 \ /
  Last update: 2019-11-14 00:42    [W:0.080 / U:5.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site