| Subject | Re: [PATCH AUTOSEL 4.14 014/115] ata: ahci_brcm: Match BCM63138 compatible strings | From | Florian Fainelli <> | Date | Wed, 13 Nov 2019 12:07:25 -0800 |
| |
On 11/12/19 5:54 PM, Sasha Levin wrote: > From: Florian Fainelli <f.fainelli@gmail.com> > > [ Upstream commit fb8506f15f2e394f5f648575cf48a26e8744390c ] > > Match the "brcm,bcm63138-ahci" compatible string in order to allow this > driver to probe on such platforms. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > Signed-off-by: Sasha Levin <sashal@kernel.org>
This is a feature and not really a bug fix, is someone specifically asking for this to be back ported? Also without the matching SATA PHY driver changes:
7b69fa1c5c930886f8a916cc47096dd4044c007a ("phy: brcm-sata: Add BCM63138 (DSL) PHY init sequence")
this is pretty useless on its own. Same applies to all automatic selections, not just this kernel obviously.
> --- > drivers/ata/ahci_brcm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c > index 5936d1679bf3a..0a3998526bb1d 100644 > --- a/drivers/ata/ahci_brcm.c > +++ b/drivers/ata/ahci_brcm.c > @@ -297,6 +297,7 @@ static struct scsi_host_template ahci_platform_sht = { > static const struct of_device_id ahci_of_match[] = { > {.compatible = "brcm,bcm7425-ahci", .data = (void *)BRCM_SATA_BCM7425}, > {.compatible = "brcm,bcm7445-ahci", .data = (void *)BRCM_SATA_BCM7445}, > + {.compatible = "brcm,bcm63138-ahci", .data = (void *)BRCM_SATA_BCM7445}, > {.compatible = "brcm,bcm-nsp-ahci", .data = (void *)BRCM_SATA_NSP}, > {}, > }; >
-- Florian
|