Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH v5 1/6] ASoC: amd:Create multiple I2S platform device Endpoint | From | Pierre-Louis Bossart <> | Date | Wed, 13 Nov 2019 10:11:48 -0600 |
| |
> static void snd_acp3x_remove(struct pci_dev *pci) > { > + int i; > struct acp3x_dev_data *adata = pci_get_drvdata(pci);
nit-pick: a lot of kernel folks like xmas-tree style, with counters and return status declared last.
> > - platform_device_unregister(adata->pdev); > + if (adata->acp3x_audio_mode == ACP3x_I2S_MODE) { > + for (i = 0 ; i < ACP3x_DEVS ; i++) > + platform_device_unregister(adata->pdev[i]); > + } > iounmap(adata->acp3x_base); > > pci_disable_msi(pci);
| |