Messages in this thread | | | Date | Wed, 13 Nov 2019 09:34:27 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 03/10] ftrace: Add register_ftrace_direct() |
| |
On Wed, 13 Nov 2019 15:13:44 +0100 (CET) Miroslav Benes <mbenes@suse.cz> wrote:
> > @@ -1757,6 +1761,18 @@ static bool __ftrace_hash_rec_update(struct ftrace_ops *ops, > > return false; > > rec->flags--; > > > > + if (ops->flags & FTRACE_OPS_FL_DIRECT) > > + rec->flags &= ~FTRACE_FL_DIRECT; > > + > > + /* > > + * Only the internal direct_ops should have the > > + * DIRECT flag set. Thus, if it is removing a > > + * function, then that function should no longer > > + * be direct. > > + */ > > + if (ops->flags & FTRACE_OPS_FL_DIRECT) > > + rec->flags &= ~FTRACE_FL_DIRECT; > > + > > The flag is dropped twice here.
Ah, thanks for pointing this out. It appears that a rebase I did (where I modified and rebased on a previous version) add this as a new change (with the comment).
-- Steve
| |