Messages in this thread | | | From | Candle Sun <> | Date | Wed, 13 Nov 2019 17:40:39 +0800 | Subject | Re: [PATCH v4] HID: core: check whether Usage Page item is after Usage ID items |
| |
On Wed, Nov 13, 2019 at 9:08 AM Candle Sun <candlesea@gmail.com> wrote: > > On Tue, Nov 12, 2019 at 11:18 PM Benjamin Tissoires > <benjamin.tissoires@redhat.com> wrote: > > > > Hi all, > > > > On Tue, Nov 12, 2019 at 2:57 PM Jiri Kosina <jikos@kernel.org> wrote: > > > > > > On Tue, 22 Oct 2019, Candle Sun wrote: > > > > > > > From: Candle Sun <candle.sun@unisoc.com> > > > > > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > > > to Main item") adds support for Usage Page item after Usage ID items > > > > (such as keyboards manufactured by Primax). > > > [ ... snip ... ] > > > > > > Benjamin, > > > > > > are you planning to run this through your testsuite against regressions? > > > > > > I believe that's the last missing step, otherwise I'd be fine merging > > > this. > > > > Sorry I had to deal with family issues 2 weeks ago, and now RHEL is > > coming back at me and eating all my time. > > > > The kernel patch is now OK, so we can grab it now (either you take it > > Jiri, and add my acked-by or I'll push it later...) > > > > Candle, can you rework > > https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/58 so > > that it mirrors the kernel code (and get rid of the > > self.local.usage_page_last logic)? > > > > Cheers, > > Benjamin > > > > Thanks Jiri and Benjamin. > I will rework the hid-tools patch ASAP. > > Regards, > Candle >
Hi Benjamin, The MR for hid-tools is updated: https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/62
Thanks, Candle
> > > > > > Thanks, > > > > > > -- > > > Jiri Kosina > > > SUSE Labs > > > > >
| |