Messages in this thread Patch in this message | | | Date | Tue, 12 Nov 2019 07:16:54 -0000 | From | "tip-bot2 for Arnd Bergmann" <> | Subject | [tip: timers/urgent] ntp/y2038: Remove incorrect time_t truncation |
| |
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: 2f5841349df281ecf8f81cc82d869b8476f0db0b Gitweb: https://git.kernel.org/tip/2f5841349df281ecf8f81cc82d869b8476f0db0b Author: Arnd Bergmann <arnd@arndb.de> AuthorDate: Fri, 08 Nov 2019 21:34:24 +01:00 Committer: Thomas Gleixner <tglx@linutronix.de> CommitterDate: Tue, 12 Nov 2019 08:13:44 +01:00
ntp/y2038: Remove incorrect time_t truncation
A cast to 'time_t' was accidentally left in place during the conversion of __do_adjtimex() to 64-bit timestamps, so the resulting value is incorrectly truncated.
Remove the cast so the 64-bit time gets propagated correctly.
Fixes: ead25417f82e ("timex: use __kernel_timex internally") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/20191108203435.112759-2-arnd@arndb.de
--- kernel/time/ntp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c index 65eb796..069ca78 100644 --- a/kernel/time/ntp.c +++ b/kernel/time/ntp.c @@ -771,7 +771,7 @@ int __do_adjtimex(struct __kernel_timex *txc, const struct timespec64 *ts, /* fill PPS status fields */ pps_fill_timex(txc); - txc->time.tv_sec = (time_t)ts->tv_sec; + txc->time.tv_sec = ts->tv_sec; txc->time.tv_usec = ts->tv_nsec; if (!(time_status & STA_NANO)) txc->time.tv_usec = ts->tv_nsec / NSEC_PER_USEC;
| |