Messages in this thread | | | Subject | Re: [PATCH net,v2 1/3] net: ethernet: mediatek: Integrate GDM/PSE setup operations | From | mtk15127 <> | Date | Tue, 12 Nov 2019 15:12:20 +0800 |
| |
On Mon, 2019-11-11 at 21:56 -0800, David Miller wrote: > From: MarkLee <Mark-MC.Lee@mediatek.com> > Date: Mon, 11 Nov 2019 14:51:27 +0800 > > > +static void mtk_gdm_config(struct mtk_eth *eth, u32 config) > > +{ > > + int i; > > + > > + for (i = 0; i < MTK_MAC_COUNT; i++) { > > + u32 val = mtk_r32(eth, MTK_GDMA_FWD_CFG(i)); > > + > > + /* default setup the forward port to send frame to PDMA */ > > + val &= ~0xffff; > > + > > + /* Enable RX checksum */ > > + val |= MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN; > > + > > + val |= config; > > + > > + mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i)); > > + } > > + /*Reset and enable PSE*/ > > Please put spaces before and after the comment sentence, like: > > /* Reset and enable PSE */ > Thanks for the reminder, will correct it in the next patch.
| |