Messages in this thread | | | Date | Tue, 12 Nov 2019 07:29:51 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers |
| |
* Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> +config DEBUG_VM_PGTABLE > + bool "Debug arch page table for semantics compliance" > + depends on MMU > + depends on DEBUG_VM > + depends on ARCH_HAS_DEBUG_VM_PGTABLE > + help > + This option provides a debug method which can be used to test > + architecture page table helper functions on various platforms in > + verifying if they comply with expected generic MM semantics. This > + will help architecture code in making sure that any changes or > + new additions of these helpers still conform to expected > + semantics of the generic MM. > + > + If unsure, say N.
Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages, why not make this 'default y' to maximize testing coverage? The code size increase should be minimal, and DEBUG_VM increases size anyway.
Other than that this looks good to me:
Reviewed-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
| |