| Date | Mon, 11 Nov 2019 22:15:36 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 13/17] remoteproc/omap: add support for system suspend/resume |
| |
On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote: > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c [..] > +static int _omap_rproc_suspend(struct rproc *rproc)
I think it would make sense to inline this and _omap_rproc_resume() in their single call sites.
[..] > +static int _omap_rproc_resume(struct rproc *rproc) > +{ [..] > @@ -806,6 +972,14 @@ static int omap_rproc_probe(struct platform_device *pdev) > oproc->num_timers); > } > > + init_completion(&oproc->pm_comp); > + > + oproc->fck = of_clk_get(np, 0);
devm_clk_get() ?
Otherwise I think you're lacking a clk_put() in omap_rproc_remove()
Regards, Bjorn
|