lkml.org 
[lkml]   [2019]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 079/115] iwlwifi: mvm: don't send keys when entering D3
    Date
    From: Sara Sharon <sara.sharon@intel.com>

    [ Upstream commit 8c7fd6a365eb5b2647b2c01918730d0a485b9f85 ]

    In the past, we needed to program the keys when entering D3. This was
    since we replaced the image. However, now that there is a single
    image, this is no longer needed. Note that RSC is sent separately in
    a new command. This solves issues with newer devices that support PN
    offload. Since driver re-sent the keys, the PN got zeroed and the
    receiver dropped the next packets, until PN caught up again.

    Signed-off-by: Sara Sharon <sara.sharon@intel.com>
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
    index b205a7bfb828d..65c51c6983288 100644
    --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
    +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
    @@ -947,8 +947,10 @@ int iwl_mvm_wowlan_config_key_params(struct iwl_mvm *mvm,
    {
    struct iwl_wowlan_kek_kck_material_cmd kek_kck_cmd = {};
    struct iwl_wowlan_tkip_params_cmd tkip_cmd = {};
    + bool unified = fw_has_capa(&mvm->fw->ucode_capa,
    + IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG);
    struct wowlan_key_data key_data = {
    - .configure_keys = !d0i3,
    + .configure_keys = !d0i3 && !unified,
    .use_rsc_tsc = false,
    .tkip = &tkip_cmd,
    .use_tkip = false,
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-11-13 03:12    [W:5.456 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site