lkml.org 
[lkml]   [2019]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/3] watchdog: sama5d4_wdt: cleanup the bit definitions
    Hi,

    I love your patch! Perhaps something to improve:

    [auto build test WARNING on robh/for-next]
    [also build test WARNING on v5.4-rc7 next-20191112]
    [if your patch is applied to the wrong git tree, please drop us a note to help
    improve the system. BTW, we also suggest to use '--base' option to specify the
    base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

    url: https://github.com/0day-ci/linux/commits/Eugen-Hristev-microchip-com/watchdog-sama5d4_wdt-cleanup-the-bit-definitions/20191113-023558
    base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
    config: ia64-allmodconfig (attached as .config)
    compiler: ia64-linux-gcc (GCC) 7.4.0
    reproduce:
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # save the attached .config to linux build tree
    GCC_VERSION=7.4.0 make.cross ARCH=ia64

    If you fix the issue, kindly add following tag
    Reported-by: kbuild test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    drivers/watchdog/at91sam9_wdt.c: In function 'at91_wdt_reset':
    >> drivers/watchdog/at91sam9_wdt.c:43:17: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    writel_relaxed((val), (wdt)->base + (field))
    ^
    >> drivers/watchdog/at91sam9_wdt.c:114:2: note: in expansion of macro 'wdt_write'
    wdt_write(wdt, AT91_WDT_CR, AT91_WDT_KEY | AT91_WDT_WDRSTT);
    ^~~~~~~~~
    --
    In file included from drivers/watchdog/sama5d4_wdt.c:19:0:
    drivers/watchdog/sama5d4_wdt.c: In function 'sama5d4_wdt_ping':
    >> drivers/watchdog/at91sam9_wdt.h:18:24: warning: large integer implicitly truncated to unsigned type [-Woverflow]
    #define AT91_WDT_KEY (0xa5 << 24) /* KEY Password */
    ^
    >> drivers/watchdog/sama5d4_wdt.c:101:30: note: in expansion of macro 'AT91_WDT_KEY'
    wdt_write(wdt, AT91_WDT_CR, AT91_WDT_KEY | AT91_WDT_WDRSTT);
    ^~~~~~~~~~~~

    vim +18 drivers/watchdog/at91sam9_wdt.h

    eaa595cb881bba include/asm-arm/arch-at91rm9200/at91_wdt.h Andrew Victor 2006-11-30 15
    c1c30a29df7e47 drivers/watchdog/at91sam9_wdt.h Jean-Christophe PLAGNIOL-VILLARD 2011-11-02 16 #define AT91_WDT_CR 0x00 /* Watchdog Control Register */
    70008fc3a14154 drivers/watchdog/at91sam9_wdt.h Eugen Hristev 2019-11-11 17 #define AT91_WDT_WDRSTT BIT(0) /* Restart */
    0e5f82dda5e60a include/asm-arm/arch-at91/at91_wdt.h Andrew Victor 2007-05-31 @18 #define AT91_WDT_KEY (0xa5 << 24) /* KEY Password */
    eaa595cb881bba include/asm-arm/arch-at91rm9200/at91_wdt.h Andrew Victor 2006-11-30 19

    :::::: The code at line 18 was first introduced by commit
    :::::: 0e5f82dda5e60a21cf8ba4f77334d60290277d2c [ARM] 4421/1: AT91: Value of _KEY fields.

    :::::: TO: Andrew Victor <andrew@sanpeople.com>
    :::::: CC: Russell King <rmk+kernel@arm.linux.org.uk>

    ---
    0-DAY kernel test infrastructure Open Source Technology Center
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2019-11-12 22:25    [W:3.856 / U:25.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site