lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 073/125] HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()
    Date
    From: Zhang Lixu <lixu.zhang@intel.com>

    [ Upstream commit 16ff7bf6dbcc6f77d2eec1ac9120edf44213c2f1 ]

    When allocating tx ring buffers failed, should free tx buffers, not rx buffers.

    Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
    Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
    index b9b917d2d50db..c41dbb167c91b 100644
    --- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
    +++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
    @@ -90,7 +90,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
    return 0;
    out:
    dev_err(&cl->device->dev, "error in allocating Tx pool\n");
    - ishtp_cl_free_rx_ring(cl);
    + ishtp_cl_free_tx_ring(cl);
    return -ENOMEM;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-11 19:45    [W:4.028 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site