Messages in this thread | | | Date | Mon, 11 Nov 2019 09:02:25 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH v5 10/13] perf stat: Use affinity for opening events |
| |
> > #include <linux/time64.h> > > @@ -440,6 +441,7 @@ static enum counter_recovery stat_handle_error(struct evsel *counter) > > ui__warning("%s event is not supported by the kernel.\n", > > perf_evsel__name(counter)); > > counter->supported = false; > > + counter->errored = true; > > how is errored different from supported? > why can't you use it?
errored means that the event is still partially open, while supported means it is closed. While I guess it could be combined it seems cleaner to keep them separate.
-Andi
| |