lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA
    Hi Kees,

    On Fri, Oct 11, 2019 at 2:07 AM Kees Cook <keescook@chromium.org> wrote:
    > There's no reason to keep the RODATA macro: replace the callers with
    > the expected RO_DATA macro.
    >
    > Signed-off-by: Kees Cook <keescook@chromium.org>
    > ---
    > arch/alpha/kernel/vmlinux.lds.S | 2 +-
    > arch/ia64/kernel/vmlinux.lds.S | 2 +-
    > arch/microblaze/kernel/vmlinux.lds.S | 2 +-
    > arch/mips/kernel/vmlinux.lds.S | 2 +-
    > arch/um/include/asm/common.lds.S | 2 +-
    > arch/xtensa/kernel/vmlinux.lds.S | 2 +-
    > include/asm-generic/vmlinux.lds.h | 4 +---
    > 7 files changed, 7 insertions(+), 9 deletions(-)

    Somehow you missed:

    arch/m68k/kernel/vmlinux-std.lds: RODATA
    arch/m68k/kernel/vmlinux-sun3.lds: RODATA

    Leading to build failures in next-20191111:

    /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29:
    syntax error
    make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1

    Reported-by: noreply@ellerman.id.au
    http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/

    Gr{oetje,eeting}s,

    Geert


    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2019-11-11 17:59    [W:5.607 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site