Messages in this thread | | | From | David Abdurachmanov <> | Date | Mon, 11 Nov 2019 16:05:40 +0200 | Subject | Re: [PATCH] RISC-V: Enable SYSCON reboot and poweroff drivers |
| |
On Mon, Nov 11, 2019 at 3:43 PM Anup Patel <Anup.Patel@wdc.com> wrote: > > Correct Palmer's email address > > > -----Original Message----- > > From: Anup Patel > > Sent: Monday, November 11, 2019 7:05 PM > > To: Palmer Dabbelt <palmer@sifive.com>; Paul Walmsley > > <paul.walmsley@sifive.com> > > Cc: Atish Patra <Atish.Patra@wdc.com>; Alistair Francis > > <Alistair.Francis@wdc.com>; Christoph Hellwig <hch@lst.de>; Anup Patel > > <anup@brainfault.org>; linux-riscv@lists.infradead.org; linux- > > kernel@vger.kernel.org; Anup Patel <Anup.Patel@wdc.com> > > Subject: [PATCH] RISC-V: Enable SYSCON reboot and poweroff drivers > > > > We can use SYSCON reboot and poweroff drivers for the SiFive test device > > found on QEMU virt machine and SiFive SOCs. > > > > This patch enables SYSCON reboot and poweroff drivers in RV64 and RV32 > > defconfigs. > > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > --- > > arch/riscv/configs/defconfig | 4 ++++ > > arch/riscv/configs/rv32_defconfig | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > > index 420a0dbef386..73a6ee31a7d2 100644 > > --- a/arch/riscv/configs/defconfig > > +++ b/arch/riscv/configs/defconfig > > @@ -63,6 +63,10 @@ CONFIG_HW_RANDOM_VIRTIO=y CONFIG_SPI=y > > CONFIG_SPI_SIFIVE=y # CONFIG_PTP_1588_CLOCK is not set > > +CONFIG_POWER_RESET=y
Why not to add
select POWER_RESET
to arch/riscv/Kconfig ?
This seems to be a popular choice (?). I went this path recently while enabling gpio-restart on SiFive Unleashed on a private branch.
[..] arch/arm/mach-exynos/Kconfig: select POWER_RESET arch/arm/mach-exynos/Kconfig: select POWER_RESET_SYSCON arch/arm/mach-exynos/Kconfig: select POWER_RESET_SYSCON_POWEROFF arch/arm/mach-gemini/Kconfig: select POWER_RESET arch/arm/mach-gemini/Kconfig: select POWER_RESET_GEMINI_POWEROFF arch/arm/mach-gemini/Kconfig: select POWER_RESET_SYSCON arch/arm/mach-hisi/Kconfig: select POWER_RESET arch/arm/mach-hisi/Kconfig: select POWER_RESET_HISI arch/arm/mach-integrator/Kconfig: select POWER_RESET arch/arm/mach-integrator/Kconfig: select POWER_RESET_VERSATILE arch/arm/mach-realview/Kconfig: select POWER_RESET arch/arm/mach-realview/Kconfig: select POWER_RESET_VERSATILE arch/arm/mach-versatile/Kconfig: select POWER_RESET arch/arm/mach-versatile/Kconfig: select POWER_RESET_VERSATILE arch/arm/mach-vexpress/Kconfig: select POWER_RESET arch/arm/mach-vexpress/Kconfig: select POWER_RESET_VEXPRESS arch/arm64/Kconfig: select POWER_RESET [..]
> > +CONFIG_POWER_RESET_SYSCON=y > > +CONFIG_POWER_RESET_SYSCON_POWEROFF=y > > +CONFIG_SYSCON_REBOOT_MODE=y > > CONFIG_DRM=y > > CONFIG_DRM_RADEON=y > > CONFIG_DRM_VIRTIO_GPU=y > > diff --git a/arch/riscv/configs/rv32_defconfig > > b/arch/riscv/configs/rv32_defconfig > > index 87ee6e62b64b..1429e1254295 100644 > > --- a/arch/riscv/configs/rv32_defconfig > > +++ b/arch/riscv/configs/rv32_defconfig > > @@ -61,6 +61,10 @@ CONFIG_VIRTIO_CONSOLE=y > > CONFIG_HW_RANDOM=y CONFIG_HW_RANDOM_VIRTIO=y # > > CONFIG_PTP_1588_CLOCK is not set > > +CONFIG_POWER_RESET=y > > +CONFIG_POWER_RESET_SYSCON=y > > +CONFIG_POWER_RESET_SYSCON_POWEROFF=y > > +CONFIG_SYSCON_REBOOT_MODE=y > > CONFIG_DRM=y > > CONFIG_DRM_RADEON=y > > CONFIG_DRM_VIRTIO_GPU=y > > -- > > 2.17.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
| |