lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: report initial event parsing error
On Fri, Nov 08, 2019 at 10:15:33AM -0800, Ian Rogers wrote:

SNIP

> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 43c05eae1768..46a72ecac427 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3016,11 +3016,18 @@ static bool evlist__add_vfs_getname(struct evlist *evlist)
> {
> bool found = false;
> struct evsel *evsel, *tmp;
> - struct parse_events_error err = { .idx = 0, };
> - int ret = parse_events(evlist, "probe:vfs_getname*", &err);
> + struct parse_events_error err;
> + int ret;
>
> - if (ret)
> + bzero(&err, sizeof(err));

hum, what's the problem with the zero init above?

jirka

\
 
 \ /
  Last update: 2019-11-11 13:02    [W:0.181 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site