lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 2/4] firmware: meson_sm: Add secure power domain support
    From
    Date
    Hi Kevin,

    Please see my comments below:

    On 2019/11/10 4:11, Kevin Hilman wrote:
    > Jianxin Pan <jianxin.pan@amlogic.com> writes:
    >
    >> The Amlogic Meson A1/C1 Secure Monitor implements calls to control power
    >> domain.
    >>
    >> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
    >> ---
    >> drivers/firmware/meson/meson_sm.c | 2 ++
    >> include/linux/firmware/meson/meson_sm.h | 2 ++
    >> 2 files changed, 4 insertions(+)
    >>
    [...]
    >> diff --git a/include/linux/firmware/meson/meson_sm.h b/include/linux/firmware/meson/meson_sm.h
    >> index 6669e2a..4ed3989 100644
    >> --- a/include/linux/firmware/meson/meson_sm.h
    >> +++ b/include/linux/firmware/meson/meson_sm.h
    >> @@ -12,6 +12,8 @@ enum {
    >> SM_EFUSE_WRITE,
    >> SM_EFUSE_USER_MAX,
    >> SM_GET_CHIP_ID,
    >> + SM_PWRC_SET,
    >> + SM_PWRC_GET,
    >
    > These new IDs are unique to the A1/C1 family. Maybe we should add a
    > prefix to better indicate that. Maybe:
    >
    > SM_A1_PWRC_SET,
    > SM_A1_PWRC_GET,
    >
    > Thoughts?
    >
    I consulted with the internal VLSI team, and it's likely that the latter new SOC will follow A1/C1.
    And then it may become common function in the future.
    > Kevin
    >
    > .
    >

    \
     
     \ /
      Last update: 2019-11-11 11:46    [W:2.640 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site