Messages in this thread | | | From | Ard Biesheuvel <> | Date | Mon, 11 Nov 2019 09:44:05 +0000 | Subject | Re: [PATCH] efi: Fix comment for efi_mem_type() wrt absent physical addresses |
| |
On Mon, 11 Nov 2019 at 05:27, Anshuman Khandual <anshuman.khandual@arm.com> wrote: > > On 11/11/2019 10:43 AM, Anshuman Khandual wrote: > > A previous commit f99afd08a45f ("efi: Update efi_mem_type() to return an > > error rather than 0") changed the return type from EFI_RESERVED_TYPE to > > -EINVAL when the searched physical address is not present in any memory > > descriptor. But the comment preceding the function never changed. Lets > > change the comment now to reflect the new return type -EINVAL. > > In the subject line, s/PATCH/PATCH V2/. Not sending yet another patch just > to fix this (in order to reduce spam). But please let me know in case that > will be essential. >
No worries, I can queue it like this.
Thanks,
> > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: linux-efi@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > > --- > > Changes in V2: > > > > - Changed comment for efi_mem_type() instead of the return type per Ard > > > > V1: (https://lore.kernel.org/patchwork/patch/1149002/) > > > > drivers/firmware/efi/efi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > > index 77ca52d86e30..47b0bf7a2b7f 100644 > > --- a/drivers/firmware/efi/efi.c > > +++ b/drivers/firmware/efi/efi.c > > @@ -899,7 +899,7 @@ u64 efi_mem_attributes(unsigned long phys_addr) > > * > > * Search in the EFI memory map for the region covering @phys_addr. > > * Returns the EFI memory type if the region was found in the memory > > - * map, EFI_RESERVED_TYPE (zero) otherwise. > > + * map, -EINVAL otherwise. > > */ > > int efi_mem_type(unsigned long phys_addr) > > { > >
| |