Messages in this thread Patch in this message | | | Date | Mon, 11 Nov 2019 09:32:34 -0000 | From | "tip-bot2 for Peter Zijlstra" <> | Subject | [tip: sched/core] sched/fair: Use mul_u32_u32() |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2eeb01a28c9233333bf229a5b4b0559f4bd22b52 Gitweb: https://git.kernel.org/tip/2eeb01a28c9233333bf229a5b4b0559f4bd22b52 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Fri, 08 Nov 2019 14:15:59 +01:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Mon, 11 Nov 2019 08:35:20 +01:00
sched/fair: Use mul_u32_u32()
While reading the code I encountered another site where we should be using mul_u32_u32() because GCC just won't take a hint.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: bsegall@google.com Cc: dietmar.eggemann@arm.com Cc: juri.lelli@redhat.com Cc: ktkhai@virtuozzo.com Cc: mgorman@suse.de Cc: qais.yousef@arm.com Cc: qperret@google.com Cc: rostedt@goodmis.org Cc: valentin.schneider@arm.com Cc: vincent.guittot@linaro.org Link: https://lkml.kernel.org/r/20191108131909.717931380@infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/fair.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 1789193..ba97d1a 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -229,8 +229,7 @@ static u64 __calc_delta(u64 delta_exec, unsigned long weight, struct load_weight } } - /* hint to use a 32x32->64 mul */ - fact = (u64)(u32)fact * lw->inv_weight; + fact = mul_u32_u32(fact, lw->inv_weight); while (fact >> 32) { fact >>= 1;
| |