Messages in this thread Patch in this message | | | Date | Mon, 11 Nov 2019 09:32:36 -0000 | From | "tip-bot2 for Peter Zijlstra" <> | Subject | [tip: sched/core] sched/fair: Better document newidle_balance() |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 7277a34c6be0b2972bdd1fea88c7cef409bed5b4 Gitweb: https://git.kernel.org/tip/7277a34c6be0b2972bdd1fea88c7cef409bed5b4 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Fri, 08 Nov 2019 14:15:55 +01:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Mon, 11 Nov 2019 08:35:18 +01:00
sched/fair: Better document newidle_balance()
Whilst chasing the pick_next_task() race, there was some confusion about the newidle_balance() return values. Document them.
[ mingo: Minor edits. ]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: bsegall@google.com Cc: dietmar.eggemann@arm.com Cc: juri.lelli@redhat.com Cc: ktkhai@virtuozzo.com Cc: mgorman@suse.de Cc: qais.yousef@arm.com Cc: qperret@google.com Cc: rostedt@goodmis.org Cc: valentin.schneider@arm.com Cc: vincent.guittot@linaro.org Link: https://lkml.kernel.org/r/20191108131909.488364308@infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/sched/fair.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6e622f4..c48a695 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9941,6 +9941,11 @@ static inline void nohz_newidle_balance(struct rq *this_rq) { } /* * idle_balance is called by schedule() if this_cpu is about to become * idle. Attempts to pull tasks from other CPUs. + * + * Returns: + * < 0 - we released the lock and there are !fair tasks present + * 0 - failed, no new tasks + * > 0 - success, new (fair) tasks present */ int newidle_balance(struct rq *this_rq, struct rq_flags *rf) {
| |