Messages in this thread Patch in this message | | | Subject | Re: [PATCH -next] drm/amd/display: Fix old-style declaration | From | Joe Perches <> | Date | Mon, 11 Nov 2019 18:39:15 -0800 |
| |
On Mon, 2019-11-11 at 20:28 +0800, YueHaibing wrote: > Fix a build warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: > warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [] > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c [] > @@ -69,7 +69,7 @@ > #define DC_LOGGER \ > dc->ctx->logger > > -const static char DC_BUILD_ID[] = "production-build"; > +static const char DC_BUILD_ID[] = "production-build";
DC_BUILD_ID is used exactly once. Maybe just use it directly and remove DC_BUILD_ID instead?
--- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 1fdba13..803dc14 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -69,8 +69,6 @@ #define DC_LOGGER \ dc->ctx->logger -const static char DC_BUILD_ID[] = "production-build"; - /** * DOC: Overview * @@ -815,7 +813,7 @@ struct dc *dc_create(const struct dc_init_data *init_params) if (dc->res_pool->dmcu != NULL) dc->versions.dmcu_version = dc->res_pool->dmcu->dmcu_version; - dc->build_id = DC_BUILD_ID; + dc->build_id = "production-build"; DC_LOG_DC("Display Core initialized\n");
| |