Messages in this thread | | | From | "S.j. Wang" <> | Subject | Re: [alsa-devel] [PATCH V2 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm | Date | Mon, 11 Nov 2019 09:06:07 +0000 |
| |
Hi Rob, Nicolin
> > Hi Rob > > > > On Wed, Oct 30, 2019 at 07:41:26PM +0800, Shengjiu Wang wrote: > > > In order to support the two asrc modules in imx8qm, we need to add > > > compatible string "fsl,imx8qm-asrc0" and "fsl,imx8qm-asrc1" > > > > Are the blocks different in some way? > > > > If not, why do you need to distinguish them? > > > The internal clock mapping is different for each module. > > Or we can use one compatible string, but need add another property > "fsl,asrc-clk-map" to distinguish the different clock map. > > The change is in below. > > Which one do you think is better? > > Required properties: > > - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc". > + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc", > + "fsl,imx8qm-asrc". > > - reg : Offset and length of the register set for the device. > > @@ -35,6 +36,11 @@ Required properties: > > - fsl,asrc-width : Defines a mutual sample width used by DPCM Back > Ends. > > + - fsl,asrc-clk-map : Defines clock map used in driver. which is required > + by imx8qm > + <0> - select the map for asrc0 > + <1> - select the map for asrc1 > + > Optional properties: >
I will do a update for this change in v3.
Best regards Wang shengjiu
| |