lkml.org 
[lkml]   [2019]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 103/125] scsi: qla2xxx: stop timer in shutdown path
    Date
    From: Nicholas Piggin <npiggin@gmail.com>

    [ Upstream commit d3566abb1a1e7772116e4d50fb6a58d19c9802e5 ]

    In shutdown/reboot paths, the timer is not stopped:

    qla2x00_shutdown
    pci_device_shutdown
    device_shutdown
    kernel_restart_prepare
    kernel_restart
    sys_reboot

    This causes lockups (on powerpc) when firmware config space access calls
    are interrupted by smp_send_stop later in reboot.

    Fixes: e30d1756480dc ("[SCSI] qla2xxx: Addition of shutdown callback handler.")
    Link: https://lore.kernel.org/r/20191024063804.14538-1-npiggin@gmail.com
    Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
    Acked-by: Himanshu Madhani <hmadhani@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_os.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
    index 856a7ceb9a041..18ee614fe07f5 100644
    --- a/drivers/scsi/qla2xxx/qla_os.c
    +++ b/drivers/scsi/qla2xxx/qla_os.c
    @@ -3496,6 +3496,10 @@ qla2x00_shutdown(struct pci_dev *pdev)
    qla2x00_try_to_stop_firmware(vha);
    }

    + /* Disable timer */
    + if (vha->timer_active)
    + qla2x00_stop_timer(vha);
    +
    /* Turn adapter off line */
    vha->flags.online = 0;

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-11-11 20:03    [W:4.097 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site