lkml.org 
[lkml]   [2019]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] cpuidle: Use nanoseconds as the unit of time
On Fri, Nov 8, 2019 at 6:04 PM Doug Smythies <dsmythies@telus.net> wrote:
>
> On 2019.11.08 01:45 Rafael J. Wysocki wrote:
> > On Fri, Nov 8, 2019 at 9:45 AM Doug Smythies <dsmythies@telus.net> wrote:
> >
> ...
> >> I have been running this v2 today, with both menu and teo
> >> governors. Acquiring some baseline reference data to compare
> >> to now. The menu governor response seems different (Supporting
> >> information/graphs will come later).
> >
> > That may be good or bad, depending in what way it is different. :-)
>
> My thinking was that the differences should be minimal between
> the baseline (linux-next as of 2019.11.07) and plus your two patches.
> Because this was a change of units, but not functionality.
> Such is the case with the teo governor, but not the menu governor.
> I have not tried the ladder or haltpoll governors, and don't intend to.
>
> Now to attempt to isolate the issue in the code, which might take
> considerable time.

Thanks!

It looks like I have overlooked a unit conversion in menu or done a
unit conversion twice somewhere.

\
 
 \ /
  Last update: 2019-11-10 17:49    [W:3.730 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site