Messages in this thread | | | Subject | Re: [PATCH] drivers/base/memory.c: memory subsys init: skip search for missing blocks | From | Rick Lindsley <> | Date | Fri, 1 Nov 2019 15:32:02 -0700 |
| |
On 11/1/19 12:00 PM, David Hildenbrand wrote: > > No, I don't really like that. Can we please speed up the lookup via a radix tree as noted in the comment of "find_memory_block()".
I agree with the general sentiment that a redesign is the correct long term action - it has been for some time now - but implementing a new storage and retrieval method and verifying that it introduces no new problems itself is non-trivial. There's a reason it remains a comment.
I don't see any issues with the patch itself. Do we really want to forego the short term, low-hanging, low risk fruit in favor of waiting indefinitely for that well-tested long-term solution?
Rick
| |