Messages in this thread | | | Subject | Re: [PATCH v2] reset: brcmstb: Fix resource checks | From | Florian Fainelli <> | Date | Fri, 1 Nov 2019 12:38:27 -0700 |
| |
On 10/31/19 9:18 PM, Florian Fainelli wrote: > The use of IS_ALIGNED() is incorrect, the typical resource we pass looks > like this: start: 0x8404318, size: 0x30. When using IS_ALIGNED() we will > get the following 0x8404318 & (0x18 - 1) = 0x10 which is definitively > not equal to 0, same goes with the size. > > Replace this with an appropriate check on the start address and the > resource size to be a multiple of SW_INIT_BANK_SIZE. > > Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Philipp, I am just going to remove those register checks, this is overly cautious for no particular reason, and we actually have platforms where those registers checks would just flat out fail. Expect a v3 shortly, thanks! -- Florian
| |