lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/mce: Lower throttling MCE messages to warnings
From
Date
On Wed, 2019-10-09 at 19:56 +0200, Borislav Petkov wrote:
> On Wed, Oct 09, 2019 at 05:54:24PM +0200, Benjamin Berg wrote:
> > On modern CPUs it is quite normal that the temperature limits are
> > reached and the CPU is throttled. In fact, often the thermal design is
> > not sufficient to cool the CPU at full load and limits can quickly be
> > reached when a burst in load happens. This will even happen with
> > technologies like RAPL limitting the long term power consumption of
> > the package.
> >
> > So these messages do not usually indicate a hardware issue (e.g.
> > insufficient cooling). Log them as warnings to avoid confusion about
> > their severity.
[]
> > diff --git a/arch/x86/kernel/cpu/mce/therm_throt.c b/arch/x86/kernel/cpu/mce/therm_throt.c
[]
> > @@ -188,7 +188,7 @@ static void therm_throt_process(bool new_event, int event, int level)
> > /* if we just entered the thermal event */
> > if (new_event) {
> > if (event == THERMAL_THROTTLING_EVENT)
> > - pr_crit("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n",
> > + pr_warn("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n",
> > this_cpu,
> > level == CORE_LEVEL ? "Core" : "Package",
> > state->count);
> > --
>
> This has carried over since its very first addition in
>
> commit 3867eb75b9279c7b0f6840d2ad9f27694ba6c4e4
> Author: Dave Jones <davej@suse.de>
> Date: Tue Apr 2 20:02:27 2002 -0800
>
> [PATCH] x86 bluesmoke update.
>
> o Make MCE compile time optional (Paul Gortmaker)
> o P4 thermal trip monitoring. (Zwane Mwaikambo)
> o Non-fatal MCE logging. (Me)
>
>
> It used to be KERN_EMERG back then, though.
>
> And yes, this issue has come up in the past already so I think I'll take
> it. I'll just give Intel folks a couple of days to object should there
> be anything to object to.

Perhaps this should be

pr_warn_ratelimited(...)

as the temperature changes can be relatively quick.


\
 
 \ /
  Last update: 2019-10-09 20:06    [W:0.075 / U:37.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site