Messages in this thread | | | Date | Wed, 9 Oct 2019 10:51:49 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] proc: centralise declaration of cpuinfo_op |
| |
On Wed, Oct 09, 2019 at 12:39:30PM +0100, Ben Dooks wrote: > When building for arm, cpuinfo_op generates a warning due > to no declaration. Since this is used in fs/proc/cpuinfo.c > and inconsitently declared across archiectures move the > declaration info <linux/seq_file.h>. This means that the > cpuinfo_op will have a declaration any place it is used. > > Removes the following sparse warning: > > arch/arm/kernel/setup.c:1320:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?
I like the consolidation, but I don't think seq_file.h is the right place. A procfs or cpu topology related header seems like the better choice.
| |