lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v18 12/14] gpio: pisosr: Utilize the for_each_set_clump8 macro
    Date
    Replace verbose implementation in get_multiple callback with
    for_each_set_clump8 macro to simplify code and improve clarity.

    Cc: Morten Hein Tiljeset <morten.tiljeset@prevas.dk>
    Cc: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
    ---
    drivers/gpio/gpio-pisosr.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c
    index f809a5a8e9eb..9ab2c044ef52 100644
    --- a/drivers/gpio/gpio-pisosr.c
    +++ b/drivers/gpio/gpio-pisosr.c
    @@ -96,16 +96,16 @@ static int pisosr_gpio_get_multiple(struct gpio_chip *chip,
    unsigned long *mask, unsigned long *bits)
    {
    struct pisosr_gpio *gpio = gpiochip_get_data(chip);
    - unsigned int nbytes = DIV_ROUND_UP(chip->ngpio, 8);
    - unsigned int i, j;
    + unsigned long offset;
    + unsigned long gpio_mask;
    + unsigned long buffer_state;

    pisosr_gpio_refresh(gpio);

    bitmap_zero(bits, chip->ngpio);
    - for (i = 0; i < nbytes; i++) {
    - j = i / sizeof(unsigned long);
    - bits[j] |= ((unsigned long) gpio->buffer[i])
    - << (8 * (i % sizeof(unsigned long)));
    + for_each_set_clump8(offset, gpio_mask, mask, chip->ngpio) {
    + buffer_state = gpio->buffer[offset / 8] & gpio_mask;
    + bitmap_set_value8(bits, buffer_state, offset);
    }

    return 0;
    --
    2.23.0
    \
     
     \ /
      Last update: 2019-10-09 19:16    [W:4.508 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site