lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 08/13] vsock: move vsock_insert_unbound() in the vsock_create()
    On Fri, Sep 27, 2019 at 01:26:58PM +0200, Stefano Garzarella wrote:
    > vsock_insert_unbound() was called only when 'sock' parameter of
    > __vsock_create() was not null. This only happened when
    > __vsock_create() was called by vsock_create().
    >
    > In order to simplify the multi-transports support, this patch
    > moves vsock_insert_unbound() at the end of vsock_create().
    >
    > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
    > ---
    > net/vmw_vsock/af_vsock.c | 13 +++++++++----
    > 1 file changed, 9 insertions(+), 4 deletions(-)

    Maybe transports shouldn't call __vsock_create() directly. They always
    pass NULL as the parent socket, so we could have a more specific
    function that transports call without a parent sock argument. This
    would eliminate any concern over moving vsock_insert_unbound() out of
    this function. In any case, I've checked the code and this patch is
    correct.

    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-10-09 14:35    [W:4.036 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site